-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] javascript-lint: Use eslint instead of jshint #97
Conversation
* [REF] misc: Add npm_which_module method * [REF] test: Remove useless 'if' to custom which
ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that we need to add a .jslintrc file in MQT, isn't it?
Yes, that is right |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking into account my request.
What is required to ignore the doc folder then ?
Is there a config file to add ?
I'm a bit concerned about the +2 min on each builds, this seems a lot to me.
@yvaucher
I'll create the change to ignore them.
Yes, .jslintrc
Yes me too, but this is a issue of self-travis that have a too old version |
@yvaucher |
afa784e
to
bc9e2db
Compare
http://eslint.org/ is a tool better than jshint.
Good post about:
FYI this tool requires a upgrade of nodejs version 6 installing for travis with:
nvm install 6
This step spent +2 minutes to current time of the lint build.
Disable checks for
/doc
and/templates
folder by @yvaucher request: [IMP] javascript-lint: Enable jshint configuration file #49 (comment)ToDo: After approval this one we will need add nvm upgrade from MQT
For merger
Recovered from #87